Skip to content

[PWGDQ] update dqefficiency for acceptance check and tree production #14361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iarsene merged 4 commits into from
Jan 14, 2026
Merged

[PWGDQ] update dqefficiency for acceptance check and tree production #14361

iarsene merged 4 commits into from
Jan 14, 2026
+66 −36

Conversation

@zjxiongOvO
Copy link
Contributor

@zjxiongOvO zjxiongOvO commented Dec 30, 2025

No description provided.

@github-actions github-actions bot added the pwgdq label Dec 30, 2025
@github-actions github-actions bot changed the title update dqefficiency for acceptance check and tree production [PWGDQ] update dqefficiency for acceptance check and tree production Dec 30, 2025
@github-actions
Copy link

github-actions bot commented Dec 30, 2025 •
edited
Loading

O2 linter results: ❌ 474 errors, ⚠️ 888 warnings, 🔕 0 disabled

@alibuild
Copy link
Collaborator

alibuild commented Dec 30, 2025

Error while checking build/O2Physics/o2 for 089ccf7 at 2025-12-30 04:56:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/14361-slc9_x86-64/0/PWGDQ/Tasks/dqEfficiency_withAssoc.cxx:2258:32: error: request for member 'IsSelected' in 'accCut', which is of pointer type 'AnalysisCut*' (maybe you meant to use '->' ?)
/sw/SOURCES/O2Physics/14361-slc9_x86-64/0/PWGDQ/Tasks/dqEfficiency_withAssoc.cxx:2259:102: error: request for member 'GetName' in 'accCut', which is of pointer type 'AnalysisCut*' (maybe you meant to use '->' ?)
ninja: build stopped: subcommand failed.

Full log here.

@hyungjun-lee
Copy link
Contributor

hyungjun-lee commented Jan 14, 2026

Dear @iarsene and @mcoquet642 ,

I am writing to follow up on the status of this PR. It appears that the merge is currently pending, likely due to some minor coding convention issues.

Do you think these are significant hurdles to merging this PR, or just simple fixes? If they are blockers, I would be more than happy to address them and submit a new PR. Although I am not the original author of this PR, this update is particularly useful for my current analysis, which is why I am reaching out.

Thank you for your time and for all your work on this project.

@iarsene iarsene merged commit 1208a71 into AliceO2Group:master Jan 14, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iarsene iarsene iarsene approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@mcoquet642 mcoquet642 Awaiting requested review from mcoquet642 mcoquet642 is a code owner

@lucamicheletti93 lucamicheletti93 Awaiting requested review from lucamicheletti93 lucamicheletti93 is a code owner

Assignees

No one assigned

Labels

pwgdq

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zjxiongOvO @alibuild @hyungjun-lee @iarsene